Update Parity Coverage Docs #1332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-1332.surge.sh 🎊 |
alexrashed
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
This PR contains the changes from #1322, effectively removing a lot of duplicated test data.
I just verified that the fix is working, i.e. the coverage docs does not contain duplicated entries anymore:
-
Currently deployed environment: Contains duplicated test listings:
https://docs.localstack.cloud/references/coverage/coverage_account/
-
Preview environment: Only lists the tests once
https://localstack-docs-preview-pr-1332.surge.sh/references/coverage/coverage_account/
@HarshCasper Could you also take a quick look at this PR and then merge it please? Thanks!
HarshCasper
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 Parity Metrics Docs Update Report 📖
This PR has been automatically generated to update the AWS parity coverage docs.
It aggregates the latest parity coverage test results from our test pipeline on CircleCI as well as from our Pro integration tests.
👷🏽 Handle this PR
The following options describe how to interact with this PR / the auto-update:
✔️ Accept Changes
If the changes are satisfying, just squash-merge the PR and delete the source branch.
🚫 Ignore Changes
If you want to ignore the changes in this PR, just close the PR and do not delete the source branch. The PR will not be opened and a new PR will not be created for as long as the generated code does not change (or the branch is deleted). As soon as there are new changes, a new PR will be created.
✏️ Adapt Changes
Don't do this. The APIs are auto-generated. If you decide that the APIs should look different, you have to change the code-generation.
⏸️ Pause Updates
Remove the cron-schedule trigger of the GitHub Action workflow which creates these PRs. The action can then still be triggered manually, but it will not be executed automatically.